Fix ~3500 analyser issues

See merge request ryubing/ryujinx!44

src/Ryujinx.Common/Helpers/ConsoleHelper.cs

@@ -19,7 +19,7 @@ namespace Ryujinx.Common.Helper
         [SupportedOSPlatform("windows")]
         [LibraryImport("user32")]
         private static partial nint GetForegroundWindow();
-        
+
         [SupportedOSPlatform("windows")]
         [LibraryImport("user32")]
         [return: MarshalAs(UnmanagedType.Bool)]

src/Ryujinx.Common/Helpers/FileAssociationHelper.cs

@@ -23,7 +23,7 @@ namespace Ryujinx.Common.Helper
         public static partial void SHChangeNotify(uint wEventId, uint uFlags, nint dwItem1, nint dwItem2);
 
         public static bool IsTypeAssociationSupported => (OperatingSystem.IsLinux() || OperatingSystem.IsWindows());
-        
+
         public static bool AreMimeTypesRegistered
         {
             get
@@ -92,21 +92,21 @@ namespace Ryujinx.Common.Helper
         [SupportedOSPlatform("windows")]
         private static bool AreMimeTypesRegisteredWindows()
         {
-            return _fileExtensions.Aggregate(false, 
+            return _fileExtensions.Aggregate(false,
                 (current, ext) => current | CheckRegistering(ext)
             );
-            
+
             static bool CheckRegistering(string ext)
             {
                 RegistryKey key = Registry.CurrentUser.OpenSubKey(@$"Software\Classes\{ext}");
 
                 RegistryKey openCmd = key?.OpenSubKey(@"shell\open\command");
-                
+
                 if (openCmd is null)
                 {
                     return false;
                 }
-                
+
                 string keyValue = (string)openCmd.GetValue(string.Empty);
 
                 return keyValue is not null && (keyValue.Contains("Ryujinx") || keyValue.Contains(AppDomain.CurrentDomain.FriendlyName));
@@ -116,7 +116,7 @@ namespace Ryujinx.Common.Helper
         [SupportedOSPlatform("windows")]
         private static bool InstallWindowsMimeTypes(bool uninstall = false)
         {
-            bool registered = _fileExtensions.Aggregate(false, 
+            bool registered = _fileExtensions.Aggregate(false,
                 (current, ext) => current | RegisterExtension(ext, uninstall)
             );
 
@@ -124,7 +124,7 @@ namespace Ryujinx.Common.Helper
             SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_FLUSH, nint.Zero, nint.Zero);
 
             return registered;
-            
+
             static bool RegisterExtension(string ext, bool uninstall = false)
             {
                 string keyString = @$"Software\Classes\{ext}";
@@ -136,6 +136,7 @@ namespace Ryujinx.Common.Helper
                     {
                         return true;
                     }
+
                     Logger.Debug?.Print(LogClass.Application, $"Removing type association {ext}");
                     Registry.CurrentUser.DeleteSubKeyTree(keyString);
                     Logger.Debug?.Print(LogClass.Application, $"Removed type association {ext}");

src/Ryujinx.Common/Helpers/Patterns.cs

@@ -1,4 +1,4 @@
-using System.Text.RegularExpressions;
+using System.Text.RegularExpressions;
 
 namespace Ryujinx.Common.Helper
 {

src/Ryujinx.Common/Helpers/RefEvent.cs

@@ -1,4 +1,4 @@
-using Gommon;
+using Gommon;
 using System.Collections.Generic;
 using System.Threading;
 
@@ -7,10 +7,10 @@ namespace Ryujinx.Common.Helper
     public class RefEvent<T>
     {
         public delegate void Handler(ref T arg);
-        
+
         private readonly Lock _subLock = new();
         private readonly List<Handler> _subscriptions = [];
-    
+
         public bool HasSubscribers
         {
             get

src/Ryujinx.Common/Helpers/RunningPlatform.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Runtime.InteropServices;
 // ReSharper disable MemberCanBePrivate.Global
 // ReSharper disable InconsistentNaming
@@ -9,14 +9,14 @@ namespace Ryujinx.Common.Helper
     {
         MacOS,
         Linux,
-        Windows   
+        Windows
     }
-    
+
     public static class RunningPlatform
     {
-        public static readonly OperatingSystemType CurrentOS 
-            = IsMacOS 
-                ? OperatingSystemType.MacOS 
+        public static readonly OperatingSystemType CurrentOS
+            = IsMacOS
+                ? OperatingSystemType.MacOS
                 : IsWindows
                     ? OperatingSystemType.Windows
                     : IsLinux
@@ -25,21 +25,21 @@ namespace Ryujinx.Common.Helper
 
         public static Architecture Architecture => RuntimeInformation.OSArchitecture;
         public static Architecture CurrentProcessArchitecture => RuntimeInformation.ProcessArchitecture;
-        
+
         public static bool IsMacOS => OperatingSystem.IsMacOS();
         public static bool IsWindows => OperatingSystem.IsWindows();
         public static bool IsLinux => OperatingSystem.IsLinux();
-        
+
         public static bool IsArm => Architecture is Architecture.Arm64;
-        
+
         public static bool IsX64 => Architecture is Architecture.X64;
 
         public static bool IsIntelMac => IsMacOS && IsX64;
         public static bool IsArmMac => IsMacOS && IsArm;
-        
+
         public static bool IsX64Windows => IsWindows && IsX64;
         public static bool IsArmWindows => IsWindows && IsArm;
-        
+
         public static bool IsX64Linux => IsLinux && IsX64;
         public static bool IsArmLinux => IsLinux && IsArmMac;
     }