Structural and Memory Safety Improvements, Analyzer Cleanup (ryubing/ryujinx!47)

See merge request ryubing/ryujinx!47

src/Ryujinx.Cpu/AppleHv/DummyDiskCacheLoadState.cs

@@ -1,17 +0,0 @@
-using System;
-
-namespace Ryujinx.Cpu.AppleHv
-{
-    public class DummyDiskCacheLoadState : IDiskCacheLoadState
-    {
-#pragma warning disable CS0067 // The event is never used
-        /// <inheritdoc/>
-        public event Action<LoadState, int, int> StateChanged;
-#pragma warning restore CS0067
-
-        /// <inheritdoc/>
-        public void Cancel()
-        {
-        }
-    }
-}

src/Ryujinx.Cpu/AppleHv/HvApi.cs

@@ -6,11 +6,11 @@ namespace Ryujinx.Cpu.AppleHv
 {
     struct HvVcpuExitException
     {
-#pragma warning disable CS0649 // Field is never assigned to
+
         public ulong Syndrome;
         public ulong VirtualAddress;
         public ulong PhysicalAddress;
-#pragma warning restore CS0649
+
     }
 
     enum HvExitReason : uint
@@ -23,10 +23,10 @@ namespace Ryujinx.Cpu.AppleHv
 
     struct HvVcpuExit
     {
-#pragma warning disable CS0649 // Field is never assigned to
+
         public HvExitReason Reason;
         public HvVcpuExitException Exception;
-#pragma warning restore CS0649
+
     }
 
     enum HvReg : uint

src/Ryujinx.Cpu/DummyDiskCacheLoadState.cs

@@ -4,10 +4,10 @@ namespace Ryujinx.Cpu
 {
     public class DummyDiskCacheLoadState : IDiskCacheLoadState
     {
-#pragma warning disable CS0067 // The event is never used
         /// <inheritdoc/>
         public event Action<LoadState, int, int> StateChanged;
-#pragma warning restore CS0067
+
+        public DummyDiskCacheLoadState() => StateChanged?.Invoke(LoadState.Unloaded, 0, 0);
 
         /// <inheritdoc/>
         public void Cancel()

src/Ryujinx.Cpu/TickSource.cs

@@ -15,7 +15,6 @@ namespace Ryujinx.Cpu
         /// <inheritdoc/>
         public ulong Counter => (ulong)(ElapsedSeconds * Frequency);
 
-
         public long TickScalar { get; set; }
 
         private static long _acumElapsedTicks;