Ayyyy, welcome to the UI: Actions Menu → XCI Trimmer PR!
Let's keep it up!
This is the second PR in a series aimed at delivering the largest overhaul and improvements to the `Actions` menu yet.
This second PR introduces visual improvements to the `XCI Trimmer` and also fixes some bugs.
### GENERAL:
* **Renamed:** `XCI Trimmer` files to use the capitalised XCI instead of Xci
* Files were inconsistently named with either Xci or XCI. As such, they were all renamed to use XCI.
### LOCALISATION:
* **Fractured:** More locales
* `Common_Search.json` - search-related locales
* `Common_Sort.json` - sorting fields, ascending/descending locales
* `Dialog_XCITrimmer.json` - XCI trimmer dialogs
* `GameListContextMenu.json` - all UI dialogs related to the game list menu (right-click game)
* `XCITrimmer.json` - all UI-related locales for the XCI Trimmer window
* **Added:** Additional entry to `StatusBar.json`
* **Added:** `Simulate Wake-Up Message` to `MenuBar_Actions.json` (previously did not exist there, for some reason).
**NOTE:** `Common_Search.json` and `Common_Sort.json` were not fully populated, but many more locales will be added and cleaned up in future PRs.
### XCI TRIMMER:
* **Renamed:** `Trim XCI Files` menu → `XCI Trimmer`
* **XCI Trimmer (Window):**
* **Renamed:** Window title from `XCI File Trimmer` → `XCI Trimmer`
* **Renamed:** `X of Y Title(s) Selected` → `XCI Selected: X/Y`
* `Z Displayed` was renamed to `Displayed: Z` and, as usual, appears only when searching for particular XCIs in the search bar.
* **Fixed:** Counting bug
* Pressing `Select Shown` continuously would increment the amount of XCIs selected to infinity (e.g. if 5 XCIs are in the list, then you could get 1201312 of 5 Title(s) Selected). Furthermore, when you were trimming a specific number of XCIs (not the all XCIs) at once, it would show that its trimming all titles from the list (e.g. "Trimming 5 Titles" when only 1 was being trimmed).
* **Changed:** Button structure
* Previous structure included 2 buttons: `Select Shown` and `Deselect Shown`. Initially, they were renamed to `Select All` and `Deselect All`, as that sounded more natural. However, after further consideration, they were both removed and replaced by a single button, whose action and label would change depending on the state it was in:
* If no XCIs were selected → `Select All`
* If at least one XCI is selected →`Clear Selection`
* `Clear Selection` was used instead of Deselect All, because some translations were quite awkward.
* Furthermore, this reflects the way the button works: you are not "deselecting all" when only 2 out of 5 XCIs are selected - you are clearing that particular selection of XCIs.
* **Improved:** Button and Control Layout (above list)
* Sorting dropdown was expanded a bit further (150 default to 170 width), as some locales would get cutoff. This will be further adjusted in a future PR, which will tackle all of Ryujinx's sorting features.
* Added a new sorting: Trim Status
* See images for visual comparison.
* **Improved:** XCI List Layout
* The entire list was revamped to be more modern and cleaner to look at.
* Instead of displaying the file status (Trimmed, Untrimmed, Partial, Failed, Unknown), it now shows icons: Checkmark (Trimmed), Cross (Untrimmed), Wrench (Partial), Exclamation Mark (Failed), Question mark (everything else/Unknown), No Icon (when it's not XCI).
* Furthermore, it shows a Sync icon when performing the trimming/untrimming operation.
* Additionally, it shows the said status when you hover above the icons.
* Save X MB and Saved Y MB were both removed and replaced with just the amount and a percentage value (how much you save per file).
* See images for visual comparison.
* NOTE: Icons are still under consideration and may be changed in the future.
* **Improved:** Bottom Savings Display
* Instead of showing `Potential Savings`" and `Actual Savings`, the bottom row now shows the amount `Saved` AND the amount `Remaining`.
### GAME LIST CONTEXT MENU (Right-Click Game):
* **Renamed:** `Check & Trim XCI File` → `Trim XCI`
* The option already performs a check regardless.
* **Remove:** `Trim XCI` Tooltip
* The user can press the option and will be confronted with a dialog, which explains what the feature does. Furthermore, the action itself is reversible at any moment (i.e. before trimming and after trimming in the XCI Trimmer).
* It is planned to either add a message that tells the user they can untrim the XCI in the XCI Trimmer, or to make the option work both ways (Trim & Untrim). This is still under consideration, but, if chosen to be implemented, it will be a part of the Game List Context Menu PR.
* **Added:** IsVisible parameter to `Trim XCI`
* Instead of displaying `Trim XCI` for every single game (NSP, NSO, etc.), it will only be displayed for XCIs (as they are the only ones that can be trimmed). It is still _enabled_ only if an XCI is untrimmed.
* **Improved:** `Trim XCI` Dialog
* Some minor visual adjustment and organisation improvements.
* **Changed:** Value formatting for "File Size", "Game Size", and "Space Savings"
* Previously they were very long numbers, expressed in MB, with all the decimals. Instead of displaying them as such, they were shortened to display the same amount as they do in the XCI Trimmer window already.
* All further dialogs will be improved in a separate PR, because they desperately need consistency.
### STATUS BAR:
* **Adjusted:** Formatting of XCI Trimming Status on status bar
* **Forced:** Filename without extension (as we are already trimming an XCI already).
* **Fixed:** Trimming Position when Playtime is not available
* **Fixed:** Progress bar position (will be further adjusted in a Status Bar PR…boy there will be a lot of PRs, which is good)
_If there are any features or changes that you wish to be implemented, please comment down below and I'll be happy to accommodate!_
Reviewed-on: https://git.ryujinx.app/projects/Ryubing/pulls/146
Moved AppLibrary, Configuration, and PlayReport namespaces to Ryujinx.Systems, add the compat list stuff in the base Ryujinx.Systems namespace.
Moved the compatibility UI stuff to the proper UI view/viewmodel folders.
