Revert "fix/sdl3-gamepad-bugs (#19)" (#116)

This reverts commit 7f0e82fe48.

Reviewed-on: https://git.ryujinx.app/projects/Ryubing/pulls/116

src/Ryujinx.Input.SDL3/SDL3Gamepad.cs

@@ -155,9 +155,7 @@ namespace Ryujinx.Input.SDL3
                 result |= GamepadFeaturesFlag.Led;
             }
             SDL_UnlockProperties(propID);
-
+            SDL_DestroyProperties(propID);
-            // NOTE: Do not call SDL_DestroyProperties here. These properties are owned
-            // internally by SDL and are freed when SDL_CloseGamepad is called (in Dispose).
 
             return result;
         }

src/Ryujinx.Input.SDL3/SDL3GamepadDriver.cs

@@ -331,18 +331,28 @@ namespace Ryujinx.Input.SDL3
 
         public IEnumerable<IGamepad> GetGamepads()
         {
-            string[] ids;
+            lock (_gamepadsIds)
-            lock (_lock)
             {
-                ids = _gamepadsIds.Values
+                foreach (var gamepad in _gamepadsIds)
-                    .Concat(_joyConsIds.Values)
+                {
-                    .Concat(_linkedJoyConsIds.Values)
+                    yield return GetGamepad(gamepad.Value);
-                    .ToArray();
+                }
             }
 
-            foreach (string id in ids)
+            lock (_joyConsIds)
             {
-                yield return GetGamepad(id);
+                foreach (var gamepad in _joyConsIds)
+                {
+                    yield return GetGamepad(gamepad.Value);
+                }
+            }
+            
+            lock (_linkedJoyConsIds)
+            {
+                foreach (var gamepad in _linkedJoyConsIds)
+                {
+                    yield return GetGamepad(gamepad.Value);
+                }
             }
         }
     }

src/Ryujinx.Input/HLE/NpadController.cs

@@ -561,24 +561,25 @@ namespace Ryujinx.Input.HLE
                     !controllerConfig.Rumble.EnableRumble)
                 {
                     return;
+
                 }
-                
+
                 VibrationValue leftVibrationValue = dualVibrationValue.Item1;
                 VibrationValue rightVibrationValue = dualVibrationValue.Item2;
-                
+
                 leftVibrationValue.AmplitudeLow *= controllerConfig.Rumble.WeakRumble;
                 leftVibrationValue.AmplitudeHigh *= controllerConfig.Rumble.StrongRumble;
                 rightVibrationValue.AmplitudeLow *= controllerConfig.Rumble.WeakRumble;
                 rightVibrationValue.AmplitudeHigh *= controllerConfig.Rumble.StrongRumble;
-                
+
                 if (!controllerConfig.Rumble.UseHDRumble || _gamepad?.HDRumble(leftVibrationValue, rightVibrationValue) == false)
                 {
                     float low = Math.Min(1f, (float)((rightVibrationValue.AmplitudeLow * 0.85 + rightVibrationValue.AmplitudeHigh * 0.15)));
                     float high = Math.Min(1f, (float)((leftVibrationValue.AmplitudeLow * 0.15 + leftVibrationValue.AmplitudeHigh * 0.85)));
                     _gamepad?.Rumble(low, high, 0xFFFFFFFF);
                 }
-                
+
-                Logger.Debug?.Print(LogClass.Hid, $"Effect for {controllerConfig.PlayerIndex} " + 
+                Logger.Debug?.Print(LogClass.Hid, $"Effect for {controllerConfig.PlayerIndex} " +
                     // Value=value/multiplier * multiplier (result)
                     $"L.low.amp={leftVibrationValue.AmplitudeLow / controllerConfig.Rumble.WeakRumble} * {controllerConfig.Rumble.WeakRumble} ({leftVibrationValue.AmplitudeLow}), " +
                     $"L.high.amp={leftVibrationValue.AmplitudeHigh / controllerConfig.Rumble.WeakRumble} * {controllerConfig.Rumble.WeakRumble} ({leftVibrationValue.AmplitudeHigh}), " +